Skip to content

Commit

Permalink
Merge pull request #8339 from filecoin-project/backport/v1.15.1/small…
Browse files Browse the repository at this point in the history
…fixes

backport: #8338, #8337
  • Loading branch information
magik6k committed Mar 17, 2022
2 parents ff244fb + 49a4c06 commit d4cbb08
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 3 deletions.
4 changes: 2 additions & 2 deletions extern/sector-storage/manager.go
Expand Up @@ -549,10 +549,10 @@ func (m *Manager) FinalizeSector(ctx context.Context, sector storage.SectorRef,
}
}

selector := newExistingSelector(m.index, sector.ID, storiface.FTCache|storiface.FTSealed, false)
selector := newExistingSelector(m.index, sector.ID, storiface.FTCache, false)

err := m.sched.Schedule(ctx, sector, sealtasks.TTFinalize, selector,
m.schedFetch(sector, storiface.FTCache|storiface.FTSealed|unsealed, pathType, storiface.AcquireMove),
m.schedFetch(sector, storiface.FTCache|unsealed, pathType, storiface.AcquireMove),
func(ctx context.Context, w Worker) error {
_, err := m.waitSimpleCall(ctx)(w.FinalizeSector(ctx, sector, keepUnsealed))
return err
Expand Down
2 changes: 1 addition & 1 deletion extern/storage-sealing/fsm.go
Expand Up @@ -399,7 +399,7 @@ func (m *Sealing) plan(events []statemachine.Event, state *SectorInfo) (func(sta

processed, err := p(events, state)
if err != nil {
return nil, 0, xerrors.Errorf("running planner for state %s failed: %w", state.State, err)
return nil, processed, xerrors.Errorf("running planner for state %s failed: %w", state.State, err)
}

/////
Expand Down
27 changes: 27 additions & 0 deletions extern/storage-sealing/fsm_test.go
Expand Up @@ -323,6 +323,33 @@ func TestBrokenState(t *testing.T) {
}
}

func TestBadEvent(t *testing.T) {
var notif []struct{ before, after SectorInfo }
ma, _ := address.NewIDAddress(55151)
m := test{
s: &Sealing{
maddr: ma,
stats: SectorStats{
bySector: map[abi.SectorID]SectorState{},
byState: map[SectorState]int64{},
},
notifee: func(before, after SectorInfo) {
notif = append(notif, struct{ before, after SectorInfo }{before, after})
},
},
t: t,
state: &SectorInfo{State: Proving},
}

_, processed, err := m.s.Plan([]statemachine.Event{{User: SectorPacked{}}}, m.state)
require.NoError(t, err)
require.Equal(t, uint64(1), processed)
require.Equal(m.t, m.state.State, Proving)

require.Len(t, m.state.Log, 2)
require.Contains(t, m.state.Log[1].Message, "received unexpected event")
}

func TestTicketExpired(t *testing.T) {
var notif []struct{ before, after SectorInfo }
ma, _ := address.NewIDAddress(55151)
Expand Down

0 comments on commit d4cbb08

Please sign in to comment.