Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storagefsm: Fix error loop on bad event #8338

Merged
merged 1 commit into from Mar 17, 2022
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 17, 2022

Related Issues

Fixes #8307
Fixes #8316

Proposed Changes

If fsm planner returns no error, and 0 processed events, it will be called with the same events, which will cause the same errors, in a loop. This PR makes failed planners still return the number of processed events.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k requested a review from a team as a code owner March 17, 2022 15:08
@magik6k magik6k merged commit eb4bda2 into master Mar 17, 2022
@magik6k magik6k deleted the fix/fsm-badevt-loop branch March 17, 2022 15:58
@jennijuju
Copy link
Member

this fixes the kvlog file size increase as well

@Reiers
Copy link

Reiers commented Mar 30, 2022

#8376

I reproduce the issue - and it still happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't remove or terminate sector. infinite loop "state machine error" takes up all the disk space
5 participants