[Replaced] Lotus nv23 integration and testing

[rjan90]

2024-06-27 Update

This is is being closed because it has been replaced by:

1. More encompassing network upgrade tracking document: https://docs.google.com/document/d/11jN9E4IcgcbU_6acAIHuh29v7yGFj7OHiiGYpoUuSEs/edit
2. More detailed issues around things like the Lotus release: [WIP] Lotus Release v1.28.0 #12109
   The testing plans in this document have been copied out to the network upgrade tracking document.

---

This tracks the Lotus portion of the wider multi-repo/party nv23 effort that is being tracked in https://github.com/orgs/filecoin-project/projects/118. See that board's "logistics timeline" view for the most accurate dates.

Lotus nv23 integration and testing items:

Tasks

Beta Give feedback

1. Add skeleton for nv23 to support development and testing #11772
   +0
   
2. Add testing plans for FIPs targeting nv23
3. Land outstanding items for accepted FIPs in Built-In actors/FVM
4. RC for Release for FIP-0090/0092 builtin-actors#1551
5. Enable bootup from genesis (e.g., Butterfly testing) #12121
   P1 +1
   
6. [WIP] Lotus Release v1.28.0 #12109
   +0
   
7. Redo the Butterfly testnet reset with final code per https://github.com/filecoin-project/lotus-infra/blob/master/Reset_Butterfly_Network.md
8. Benchmark nv23 migration #12128
   +0

There is a separate issue for the corresponding v1.28.0 release.

[aarshkshah1992]

Testplan for #11930

• Submit a signed legacy ETH transaction to transfer FIL from account A to account B and confirm the transfer on chain
• Submit a signed legacy ETH transaction to deploy an ERC-20 contract on Filecoin
• Invoke a signed legacy ETH token transfer transaction on the above contract and ensure the balances are updated on chain
• Submit a signed legacy ETH transaction to transfer FIL from account A to account B with an incorrect signature and confirm the transfer fails

[rjan90]

Testplan for FIP-0085:

• Migration test in lotus asserting the new state of f090: FIP-0085 migration test #12139
• In a devnet setup f090 with known keys and spend some money before the network upgrade. Demonstrate that this does not work after migration.

Setup devnet with GST: https://github.com/filecoin-project/go-state-types/releases/tag/v0.14.0-dev5, which includes the migration of f090 to a keyless account actor.

1. Set the RemainderAccount to known keys:

  "RemainderAccount": {
    "Type": "multisig",
    "Balance": "300000000",
    "Meta": {
      "Signers": [
        "t1owsmgkggadc65g2sjavkyu6vdiwnuxmqs5fyqpy",
        "t1zncrhcw6bwllvz2vjehon2vposxd47ycrj6uhvy",
        "t1rldfhzcub6hql4dxe7rv3zzuwvflxtmudwxta2y"
      ],

2. Inspecting the f090:

lotus msig inspect f090
Balance: 850000000 FIL
Spendable: 850000000 FIL
Threshold: 1 / 3
Signers:
ID      Address
t0102   t1owsmgkggadc65g2sjavkyu6vdiwnuxmqs5fyqpy
t0103   t1zncrhcw6bwllvz2vjehon2vposxd47ycrj6uhvy
t0104   t1rldfhzcub6hql4dxe7rv3zzuwvflxtmudwxta2y
Transactions:  0

3. Confirming I can spend some $$ before the upgrade and migration by signing with these keys:

lotus msig propose --from=t1owsmgkggadc65g2sjavkyu6vdiwnuxmqs5fyqpy f090 t3uu5mzlnh7v6dh5wugxcp5uccefavldqblhmeyouf5vxattqfcgahp764etfp2zyysy47qd2h7odlid75mjpq 2000000
sent proposal in message:  bafy2bzaceckyqlz6q4k6qogvyw55ghxj2uj6pfhymfqpwosi7obktujx36zoa
Transaction ID: 0
Transaction was executed during propose
Exit Code: 0
Return Value: 

4. Check that balance of f090 has gone down:

lotus msig inspect f090
Balance: 848000000 FIL
Spendable: 848000000 FIL
Threshold: 1 / 3
Signers:
ID      Address
t0102   t1owsmgkggadc65g2sjavkyu6vdiwnuxmqs5fyqpy
t0103   t1zncrhcw6bwllvz2vjehon2vposxd47ycrj6uhvy
t0104   t1rldfhzcub6hql4dxe7rv3zzuwvflxtmudwxta2y
Transactions:  0

5. After the network upgrade and migration, check f090 is now a keyless account:

lotus state network-version
Network Version: 23

lotus msig inspect f090
ERROR: actor code is not multisig: account

6. Confirm that I can´t spend f090´s money:

lotus msig propose --from=t1owsmgkggadc65g2sjavkyu6vdiwnuxmqs5fyqpy f090 t3uu5mzlnh7v6dh5wugxcp5uccefavldqblhmeyouf5vxattqfcgahp764etfp2zyysy47qd2h7odlid75mjpq 2000000
ERROR: actor t090 is not a multisig actor

[rjan90]

Testing plan for FIP-0090: Non-Interactive PoRep: filecoin-project/builtin-actors#1534 (comment)

[ZenGround0]

Testing plan for FIP-0065

• itest demonstrating locked supply does not include f05 balance in nv23
• Devnet test

1. Setup devnet node to run nv22 and then migrate to nv23
2. Make some very expensive deals to set the market locked balance high. Check f05 locked balance to get an exact number of locked FIL.
3. A few epochs before migration record external circulating supply (lotus state circulating-supply) and internal approximate circulating supply (no CLI command need to query API StateVMCirculatingSupplyInternal)
4. After migration do the same
5. Compare the circulating supply values and sanity check that they are roughly different by locked market balance. This will only be approximate because circulating supply in devenet is always fluctuating anyway.

Testing steps:

Create some very expensive deals in nv22:

lotus client deal
Data CID (from lotus client import): bafkqas3gmftgu2tpmf3wmcqkmn3wcctgmvqqu5tbmjzge4tbomfge4tbbjrheylcojrheyikmjzgcylcmfzgezlubjzgcytfmjzgczlcojqwkctcojqwk4tcmvqqucq
.. calculating data size
Deal duration (days): 30
Miner Addresses (f0.. f0..), none to find: t01000
.. querying miner asks
-----
Proposing from t3vtkuwlm5zsjd45nwaassuqp2q5zf3wuzvnnkf6offcah3pt5w3qmmbyxkgvbtmxc7g4ydax2kzfxsl2gx3oa
        Balance: 49999999.999651851576283142 FIL

Piece size: 512B (Payload size: 258B)
Duration: 720h0m0s
Total price: ~30899047.8515625 FIL (47.6837158203125 FIL per epoch)
Verified: false

Accept (yes/no): yes
.. executing
Deal (t01000) CID: bafyreibutyrtq673kfwyuumgm5bxhoaj4q6lqsbtbnhqefl2xztke35xze

Check circulating supply:

lotus state  circulating-supply 
Exact circulating supply:  19076763.255135593801150817 FIL
-------
lotus state  circulating-supply --vm-supply
Circulating supply:  0 FIL
Mined:  5425.389686176467615734 FIL
Vested:  10665982.270004977404786226 FIL
Burnt:  0.000344302319213086 FIL
Locked:  30928627.681795243302307352 FIL

After network upgrade to nv23, check circulating supply again:

lotus state  circulating-supply --vm-supply
Circulating supply:  0 FIL
Mined:  18814.41414898577843093 FIL
Vested:  10746774.55432144684694266 FIL
Burnt:  0.000344308303407686 FIL
Locked:  14110.810621475185075461 FIL
-------
lotus state  circulating-supply 
Exact circulating supply:  50004705.416395983109640427 FIL

[BigLep]

Items I will do when I become part of lotus-contributors (if it doesn't get done sooner):

1. Pin the issue
2. Add it to https://github.com/orgs/filecoin-project/projects/118
3. Make a note in the issue description that "this tracks the Lotus portion of the wider multi-repo/party nv23 effort that is being tracked in https://github.com/orgs/filecoin-project/projects/118"

[rjan90]

Butterfly-Network testing

Branch: https://github.com/filecoin-project/lotus/tree/phi/nv23-butterfly-testing

• This branch is based on the latests final Lotus release (Lotus v1.27.0) with only the network consensus breaking changes applied to it.

Testingplan

@rvagg to checkbox this once e2e-testing of NI-PoRep has been completed:

• E2E-testing of NI-PoRep (FIP-0092): test: niporep: e2e testing #12105

@aarshkshah1992 / @ZenGround0

• Get the Create Migration Test for FIP-0085 in Lotus to Assert New State of f090 #12102 completed, as we will not be able to e2e-test the f090 migration in Butterfly-network.
• Redo the e2e-testing of FIP-0065: [Replaced] Lotus nv23 integration and testing #11939 (comment).
  • Be mindful when setting the upgrade epoch on Butterfly-network to have some leeway of doing the steps necessery before the network upgrade

[BigLep]

This is is being closed because it has been replaced by:

1. More encompassing network upgrade tracking document: https://docs.google.com/document/d/11jN9E4IcgcbU_6acAIHuh29v7yGFj7OHiiGYpoUuSEs/edit
2. More detailed issues around things like the Lotus release: [WIP] Lotus Release v1.28.0 #12109
   The testing plans in this document have been copied out to the network upgrade tracking document.

[BigLep]

Reopening until I get https://docs.google.com/document/d/11jN9E4IcgcbU_6acAIHuh29v7yGFj7OHiiGYpoUuSEs/edit made publicly viewable.

[rjan90]

Closing and unpinning this issue now that https://docs.google.com/document/d/11jN9E4IcgcbU_6acAIHuh29v7yGFj7OHiiGYpoUuSEs has been made publicly viewavle.