Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: niporep: e2e testing #12105

Merged
merged 3 commits into from
Jun 25, 2024
Merged

test: niporep: e2e testing #12105

merged 3 commits into from
Jun 25, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 18, 2024

Replaces #12045

Initial form here has e2e onboarding of a single sector. Need to add:

  • >1 sector in batch (note that real-proofs is quite expensive for this, so >1 sector might be slooow in CI)
  • Check sector-activated event(s) (NOTE: needs fixing in builtin-actors: https://github.com/filecoin-project/builtin-actors/pull/1537/files/#r1648458930)
  • Snap piece(s) into onboarded sector (and check events)
  • Error: 0 sectors
  • Error: >65 sectors (somehow .. maybe only with mock proofs)
  • Bad proof type, bad aggregate type (maybe)
  • One bad proof, one good (maybe, somehow, see Non Interactive Proof of Replication builtin-actors#1537 (review))
  • Bad sealer id, bad sealing number
  • Bad seal rand epoch (can't doo historical, we have a genesis chain and earliest is 180 days, but we can do future)
  • Bad proving deadline (current or next)

This branch uses filecoin-project/builtin-actors#1537 for the actors bundle, but it also has filecoin-project/builtin-actors#1553 applied on top of it because otherwise preseals don't onboard and we can't get the chain started. It also has filecoin-project/filecoin-ffi#460 applied for filecoin-ffi because we need verify-signature.

Copy link

github-actions bot commented Jun 18, 2024

All checks have passed

@rvagg
Copy link
Member Author

rvagg commented Jun 25, 2024

@rvagg rvagg changed the title test: niporep: e2e testing (WIP) test: niporep: e2e testing Jun 25, 2024
@rvagg rvagg marked this pull request as ready for review June 25, 2024 09:34
@rvagg
Copy link
Member Author

rvagg commented Jun 25, 2024

  • Added LOTUS_RUN_VERY_EXPENSIVE_TESTS and put niporep w/ real-proofs in that category. It won't run in CI because it can't. We need to work on that. See [DX Streamline] LOTUS_RUN_EXPENSIVE_TESTS periodically outside of PR workflow #12136
  • I'm cutting scope on this particular PR to get it landed. What I want to add is multi-sector onboarding, currently in both mock and real proofs we only onboard a single sector and then snap a deal into it. I think I'd like to onboard 3 sectors and have one fail but the others pass. Or at least do 2. Or some combination that makes sense and doesn't make real-proofs take too long.

Ready for review

Base automatically changed from rvagg/unmanaged-miner-improvements to master June 25, 2024 10:47
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get the test for >1 sectors in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants