feat: lp: support multiple SP IDs #11592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if I have enough context to actually review this. There's nothing obviously wrong with the code. |
magik6k
reviewed
Feb 1, 2024
storage/ctladdr/multiaddresses.go
Outdated
| "github.com/filecoin-project/lotus/chain/types" | ||
| ) | ||
|
|
||
| type MultiAddressSelector struct { |
There was a problem hiding this comment.
This is lotus-provider only right? In that case I'd move it to provider/[address.go]
magik6k
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Multi-Address support in Lotus-Provider will now offer different wallets per group of Miner IDs by expressing the same Address block as an array. A fallback singleton is provided as a migration path.
Proposed Changes
Additional Info
The issue for Multi-MinerID in Provider will be resolved
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps