Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage manager: bail out with an error if unsealed cid is undefined (redux) #3655

Merged
merged 3 commits into from
Sep 8, 2020

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Sep 8, 2020

Fixes #3558

The first attempt (#3615) included an extra logic change that caused some tests to fail. I'm investigating why it causes test failures.

This PR is the same but without the extra change: it just checks if the unsealed cid is undefined, and returns an error if so.

@dirkmc dirkmc requested a review from magik6k September 8, 2020 10:36
@magik6k magik6k merged commit 3697a1a into master Sep 8, 2020
@magik6k magik6k deleted the fix/stgmgr-undef-unsealed branch September 8, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle cid.Undef in manager.ReadPiece when there is no unsealed sector
2 participants