Update to specs-actors 0.9.9 #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested review from
Kubuxu,
magik6k,
raulk and
whyrusleeping
as code owners
This patch changes the runtime interfaces, to make it possible to abstract over them.
Stebalien
force-pushed
the
steb/specs-actors-0.9.9
branch
from
a9748e3
to
32eeb96
Compare
arajasek
reviewed
Sep 14, 2020
Comment on lines
+352
to
+354
| if err := out.UnmarshalCBOR(bytes.NewReader(ret)); err != nil { | ||
| rt.Abortf(exitcode.ErrSerialization, "failed to unmarshal return value: %s", err) | ||
| } |
There was a problem hiding this comment.
This looks like it could be consensus-critical? I assume in the old code, the exit code would've been decided by however the caller handled an error arising from ret.Into()?
In particular, I'm concerned that the return type might have been ignored in some Send calls, which would cloak the serialization error, whereas now it's guaranteed to be noticed in the internal send's exit code?
There was a problem hiding this comment.
We should only hit this if we have a bug. Honestly, we might want to panic (or do something really noisy here).
Can we run a chain import against this to see if we have ever hit a bug here?
arajasek
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the runtime interfaces, to make it possible to abstract over them.