Small consensus-critical fixes in 1.2.0 #4783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
This was referenced Nov 10, 2020
Kubuxu
force-pushed
the
release/v1.2.0
branch
from
72a3b41
to
5d9c798
Compare
magik6k
approved these changes
Nov 16, 2020
austinabell
reviewed
Nov 16, 2020
Comment on lines
+181
to
+184
| ec := exitcode.ErrSerialization | ||
| if rt.NetworkVersion() < network.Version7 { | ||
| ec = 1 | ||
| } |
There was a problem hiding this comment.
Although I don't think it's possible to hit, the encoding of params also uses this faulty exit code, perhaps do the same for this or make it fatal?
Edit: in chain/actors/params.go
There was a problem hiding this comment.
@austinabell Thanks for the suggestion! If SerializeParams fails, it's treated as a fatal error in the one place it's called (TryCreateAccountActor), so the exitcode doesn't matter.
I'm changing its returned exitcode to ErrSerialization (since that's objectively correct), but I'm not putting it behind network upgrade logic.
bibibong
pushed a commit
to EpiK-Protocol/go-epik
that referenced
this pull request
Jan 7, 2021
Small consensus-critical fixes in 1.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes all of #3478 and #3730, and most of #3267