Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small consensus-critical fixes in 1.2.0 #4783

Merged
merged 4 commits into from
Nov 17, 2020
Merged

Small consensus-critical fixes in 1.2.0 #4783

merged 4 commits into from
Nov 17, 2020

Conversation

arajasek
Copy link
Contributor

Supersedes all of #3478 and #3730, and most of #3267

Comment on lines +181 to +184
ec := exitcode.ErrSerialization
if rt.NetworkVersion() < network.Version7 {
ec = 1
}
Copy link
Contributor

@austinabell austinabell Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I don't think it's possible to hit, the encoding of params also uses this faulty exit code, perhaps do the same for this or make it fatal?

Edit: in chain/actors/params.go

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@austinabell Thanks for the suggestion! If SerializeParams fails, it's treated as a fatal error in the one place it's called (TryCreateAccountActor), so the exitcode doesn't matter.

I'm changing its returned exitcode to ErrSerialization (since that's objectively correct), but I'm not putting it behind network upgrade logic.

@arajasek arajasek changed the base branch from release/v1.2.0 to master November 17, 2020 05:16
@arajasek arajasek changed the base branch from master to release/v1.2.0 November 17, 2020 05:16
@arajasek arajasek merged commit 92b765b into release/v1.2.0 Nov 17, 2020
@arajasek arajasek deleted the asr/1.2.0 branch November 17, 2020 06:44
bibibong pushed a commit to EpiK-Protocol/go-epik that referenced this pull request Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/consensus Impact: Consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants