fix: guard against self beneficiary when deleting actor #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
force-pushed
the
fix/guard-against-self-beneficiary
branch
from
9b745c5
to
a182457
Compare
alanshaw
force-pushed
the
fix/guard-against-self-beneficiary
branch
from
a182457
to
dba166a
Compare
|
Superseded by #4783 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check to ensure the calling actor cannot specify themselves as the beneficiary - they're about to be deleted so this stops us from losing their funds.
More context and test vector for this edge case here: filecoin-project/test-vectors#92 (comment)