Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealing: Remove sector copies from workers after snapdeals #8329

Merged
merged 5 commits into from Mar 16, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 16, 2022

Related Issues

Fixes #8227

Closes #8298 (This PR achieves the same thing in a slightly different way)

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #8329 (c4259cb) into master (4906962) will increase coverage by 0.18%.
The diff coverage is 71.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8329      +/-   ##
==========================================
+ Coverage   40.14%   40.32%   +0.18%     
==========================================
  Files         679      679              
  Lines       73992    74031      +39     
==========================================
+ Hits        29705    29855     +150     
+ Misses      39101    38946     -155     
- Partials     5186     5230      +44     
Impacted Files Coverage Δ
api/version.go 80.00% <ø> (ø)
extern/sector-storage/stores/http_handler.go 73.44% <0.00%> (ø)
extern/sector-storage/worker_local.go 58.30% <50.00%> (-0.43%) ⬇️
extern/sector-storage/stores/remote.go 59.06% <65.21%> (+1.26%) ⬆️
extern/sector-storage/manager.go 62.20% <76.19%> (+0.34%) ⬆️
extern/sector-storage/stores/index.go 77.40% <100.00%> (+0.95%) ⬆️
storage/wdpost_sched.go 75.49% <0.00%> (-11.77%) ⬇️
extern/sector-storage/worker_tracked.go 79.46% <0.00%> (-7.15%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
miner/miner.go 54.75% <0.00%> (-1.97%) ⬇️
... and 31 more

@magik6k magik6k requested a review from ZenGround0 March 16, 2022 11:54
@magik6k magik6k marked this pull request as ready for review March 16, 2022 16:52
@magik6k magik6k requested a review from a team as a code owner March 16, 2022 16:52
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(SnapDeals) Files are left behind on worker even if they have become Active.
3 participants