Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: v1.15.1: feat: sealing: Remove sector copies from workers after snapdeals #8331

Merged
merged 5 commits into from Mar 16, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 16, 2022

Related Issues

Backports #8329 to v1.15.1

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k requested a review from a team as a code owner March 16, 2022 18:09
@magik6k magik6k added this to the v1.15.1 milestone Mar 16, 2022
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name tripped me up but this is good to go

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #8331 (99c6ef5) into release/v1.15.1 (ada499e) will increase coverage by 0.10%.
The diff coverage is 71.87%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.15.1    #8331      +/-   ##
===================================================
+ Coverage            40.32%   40.43%   +0.10%     
===================================================
  Files                  679      679              
  Lines                73992    74031      +39     
===================================================
+ Hits                 29838    29931      +93     
+ Misses               38920    38873      -47     
+ Partials              5234     5227       -7     
Impacted Files Coverage Δ
api/version.go 80.00% <ø> (ø)
extern/sector-storage/stores/http_handler.go 73.44% <0.00%> (ø)
extern/sector-storage/worker_local.go 58.30% <50.00%> (-0.43%) ⬇️
extern/sector-storage/stores/remote.go 59.06% <65.21%> (+1.26%) ⬆️
extern/sector-storage/manager.go 62.20% <76.19%> (+0.34%) ⬆️
extern/sector-storage/stores/index.go 77.40% <100.00%> (+0.95%) ⬆️
storage/wdpost_sched.go 75.49% <0.00%> (-3.93%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
lib/rpcenc/reader.go 70.29% <0.00%> (-1.49%) ⬇️
chain/stmgr/searchwait.go 67.30% <0.00%> (-1.29%) ⬇️
... and 24 more

@jennijuju jennijuju merged commit 5ea1502 into release/v1.15.1 Mar 16, 2022
@jennijuju jennijuju deleted the backport/v1.15.1/fix/snap-worker-cleanup branch March 16, 2022 18:20
@magik6k magik6k changed the title backport: v1.15.1: feat: sealing: Sector upgrade queue backport: v1.15.1: feat: sealing: Remove sector copies from workers after snapdeals Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants