Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release: Update release_issue_template #9150

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Aug 10, 2022

Updates the release_issue_template with some improvements:

  • Changed some wrong links (links pointed to version.go in IPFS-repo)
  • Removed Create a discussion for this release
  • Removed "Prep the changelog using scripts/mkreleaselog, and add it to CHANGELOG.md" since this already has been captured in the first pre-release/release-candiadte step. Left that you should make sure that the CHANGELOG is up to date.
  • Changed the Cut the release-link to be prerelease=false in the Stable Release step.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

Update release_issue_template.

- Changed some wrong links (links pointed to version.go in IPFS-repo)
- Removed `Create a discussion for this release`
- Removed "Prep the changelog using `scripts/mkreleaselog`, and add it to `CHANGELOG.md`" since this already has been captured in the first pre-release step. Left that you should make sure that the CHANGELOG is up to date.
@rjan90 rjan90 requested a review from a team as a code owner August 10, 2022 12:47
@rjan90 rjan90 requested a review from jennijuju August 12, 2022 11:09
@magik6k magik6k merged commit e5e8308 into master Sep 28, 2022
@magik6k magik6k deleted the phi/update-release-template branch September 28, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants