Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verifreg: serialize RmDcProposalID as int, not tuple #9206

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Aug 23, 2022

Related Issues

@jennijuju was running the remove datacap workflow on a devnet and reported that it did not work. The issue is that RmDcProposalID is serialized as an int on chain today (not a tuple), but go-state-types expects it to be a tuple.

Proposed Changes

The fix is in filecoin-project/go-state-types#51, this simply updates go-state-types to that commit and adds a test.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@arajasek arajasek requested a review from a team as a code owner August 23, 2022 19:13
@arajasek
Copy link
Contributor Author

Approve @jennijuju 's commits

@jennijuju jennijuju merged commit 1b5a1f6 into master Aug 26, 2022
@jennijuju jennijuju deleted the asr/verifreg-tuple branch August 26, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants