Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add node uptime rpc / output in info command #9436

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Oct 5, 2022

Related Issues

Proposed Changes

  • Add an Uptime jsonrpc method
  • Output uptime from node info commands

Additional Info

This in useful to double check that nodes were restarted after making some changes which could require restarting, for example.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@jennijuju
Copy link
Member

Oh what inspired this?

@magik6k
Copy link
Contributor Author

magik6k commented Oct 6, 2022

I wasn't sure if I have actually restarted my node after updating it, and this seemed like a good use of the 7 minutes of time this took to implement.

api/api_common.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants