Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v10 conformance tests #638

Closed
Stebalien opened this issue Jun 24, 2022 · 2 comments · Fixed by #1758
Closed

v10 conformance tests #638

Stebalien opened this issue Jun 24, 2022 · 2 comments · Fixed by #1758
Assignees
@Stebalien
Labels
good first issue Good for newcomers Topic: Testing
Milestone
Post-Launch Tech-...

Comments

@Stebalien
Copy link
Member

Stebalien commented Jun 24, 2022 •
edited
Loading

We need to add-back conformance tests.

  1. Extract conformance tests for v10 (first from calibrationnet, then from mainnet).
  2. Make the conformance tests download the bundle from GitHub.

Unfortunately, we can't really do this till we have a stable set of actors as changes to the actors will affect gas usage, breaking the conformance tests.

Although, I guess a half-way step would be to run conformance tests ignoring gas usage.
@shamb0 shamb0 mentioned this issue Sep 27, 2022
Closed
@maciejwitowski
Copy link
Contributor

@Stebalien Do we need it for M2.1?

@maciejwitowski maciejwitowski added this to the M2.2 milestone Oct 7, 2022
@Stebalien
Copy link
Member Author

Yes. Specifically, we need v10 conformance tests, but fixing this issue will basically get us there.

Stebalien added a commit that referenced this issue Oct 8, 2022
@Stebalien
chore: remove test-vectors submodule
ca2b0d2 
These are test vectors for v6 and v7 and aren't compatible with v10
actors.

We might as well put them in an entirely new branch/repo as cloning them
is... not fast.

Part of #638.
@Stebalien Stebalien changed the title v8+ conformance tests v10 conformance tests Nov 9, 2022
@Stebalien Stebalien modified the milestones: M2.2, M2.1 Post-Testnet Nov 9, 2022
@Stebalien Stebalien self-assigned this Apr 19, 2023
Stebalien added a commit that referenced this issue May 1, 2023
@Stebalien
feat: bring back conformance tests
ac1b442 
- Include the actor bundles in the source (compressed). They're tiny
anyways.
- Update for FVM changes.
- Re-initialize test vectors

fixes #638
@Stebalien Stebalien mentioned this issue May 1, 2023
Merged
Stebalien added a commit that referenced this issue May 1, 2023
@Stebalien
feat: bring back conformance tests
df0c791 
- Include the actor bundles in the source (compressed). They're tiny
anyways.
- Update for FVM changes.
- Re-initialize test vectors

fixes #638
Stebalien added a commit that referenced this issue May 1, 2023
@Stebalien
feat: bring back conformance tests
4a32d7c 
- Include the actor bundles in the source (compressed). They're tiny
anyways.
- Update for FVM changes.
- Re-initialize test vectors

fixes #638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
good first issue Good for newcomers Topic: Testing
Projects
None yet
Milestone
Post-Launch Tech-Debt
Development

Successfully merging a pull request may close this issue.

feat: bring back conformance tests filecoin-project/ref-fvm
3 participants
@Stebalien @raulk @maciejwitowski