Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat(storage-proofs-porep): implement NSE #1102

Closed
wants to merge 61 commits into from
Closed

[WIP] feat(storage-proofs-porep): implement NSE #1102

wants to merge 61 commits into from

Conversation

dignifiedquire
Copy link
Contributor

No description provided.

@porcuquine porcuquine added the cryptocomputelab CryptoComputeLab work label Jun 2, 2020
@dignifiedquire dignifiedquire mentioned this pull request Jun 16, 2020
Closed
@dignifiedquire dignifiedquire force-pushed the feat/nse branch 4 times, most recently from 9e421c4 to 2f3cce4 Compare June 23, 2020 08:06
@porcuquine
Copy link
Collaborator

CI is failing. Let's get this branch working completely then keep it in that state (and rebased). It's going to be around for a while as the base into which other NSE work is merged. (cc: @dignifiedquire @keyvank )

@porcuquine
Copy link
Collaborator

@dignifiedquire Can you rebase this and ensure CI passes when you have a free moment?

@dignifiedquire
Copy link
Contributor Author

@dignifiedquire Can you rebase this and ensure CI passes when you have a free moment?

rebased

@porcuquine
Copy link
Collaborator

Thanks. CI seems to have gotten worse.

@porcuquine
Copy link
Collaborator

We still have conflicts here — probably because we merged the rebased version as a PR (which did not effect a rebase here). I propose to rebase this branch, force-pushing to the head of #1225's branch for simplicity. @cryptonemo @dignifiedquire Any objections?

@porcuquine
Copy link
Collaborator

Hmm, on further inspection, I think I'm confused and that this just needs another (probably simple) rebase. Sorry, I lost the thread here.

@dignifiedquire
Copy link
Contributor Author

@porcuquine rebased

@porcuquine
Copy link
Collaborator

CI is broken.

@porcuquine
Copy link
Collaborator

@keyvank Maybe you can help repair it?

@porcuquine porcuquine added the NSE label Aug 4, 2020
@dignifiedquire dignifiedquire mentioned this pull request Nov 6, 2020
Closed
5 tasks
dignifiedquire and others added 26 commits November 19, 2020 12:18
@dignifiedquire
feat(storage-proofs-porep): setup NSE circuit boilerplate
053b675
@dignifiedquire
feat(storage-proofs-porep): implement partition proof generation
ca66c5d
@dignifiedquire
fixup rebase issues
b0fd7ea
@dignifiedquire
feat(storage-proofs-porep): implement layer based challenges
9ca9fc8 
updates
- challenge generation
- vanilla proving
- vanilla verification
@porcuquine @dignifiedquire
Refactor batch_hash for clarity.
ef0e1e8
@cryptonemo @dignifiedquire
fix: update replaced tempdir dep usages
5e4d4e3
@dignifiedquire
basic circuit proof structures
fa05838
@dignifiedquire
add missing tempdir dependency
2e15ecb
@dignifiedquire
use tempfile instead of tempdir
804051f
@dignifiedquire
tempdir fix
6ef3a7b
@dignifiedquire
switch from poseidon md to explicit arity
1b664fe
@dignifiedquire
fix parents calculation
e54a82c
@keyvank @dignifiedquire
fix: result() -> finalize() in updated sha2 crate
d0a27ff
@keyvank @dignifiedquire
increase timeout of test_ignored_release
5ee2ae7
@porcuquine @dignifiedquire
Use (varied) constant-length vector to hash column roots.
2a3c10d
@DrPeterVanNostrand @dignifiedquire
fix: nse porep challenge derivation (#1329)
6207f27
@dignifiedquire
fix compilation issues from rebase
1a2e036
@dignifiedquire
feat(storage-proofs-post): implement NSE PoSt
e84df2a
@keyvank @dignifiedquire
feat(storage-proofs): NSE - gpu implementation of encode_with_trees
4d29093 
return correct trees

results were not matching

use sealerpool

multigpu version

switch to multigpu encode_with_trees

no need to be par

run gpu version only for GPUTrees

oops

fix cast

control gpu nse through settings.rs

patch crates.io

fix errs

run on GPU by default

fix: update tree usage when using the gpu builder (#1237)

fix: update merkletree inconsistent usage as lc trees

remove println

update rust-fil-nse-gpu

switch to cpu when sealerpool is not available

remove generic-cast

log cpu/gpu

default use_gpu_nse to true

impl From for gpu::Config

refact

remove transmute

refact

refactor tests

run gpu tests separately

add gpu ci job

install rust before test

oops
@dignifiedquire
improve gpu feature setup
8f78ef9
@dignifiedquire
ci: fixup
13df90a
@dignifiedquire
ci: gpu tests
8f59b97
@dignifiedquire
happy clippy
0a364c6
@dignifiedquire
ci: add missing deps
50f8559
@dignifiedquire
fixup rebase
ca07bb6
@DrPeterVanNostrand @dignifiedquire
fix: nse comm_r
a19d3e7
@cryptonemo
Copy link
Collaborator

No longer needed. Closing PR, but branch/code will remain.

@cryptonemo cryptonemo closed this Mar 24, 2021
@porcuquine porcuquine deleted the feat/nse branch September 16, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptonemo cryptonemo Awaiting requested review from cryptonemo cryptonemo will be requested when the pull request is marked ready for review cryptonemo is a code owner

@DrPeterVanNostrand DrPeterVanNostrand Awaiting requested review from DrPeterVanNostrand DrPeterVanNostrand will be requested when the pull request is marked ready for review DrPeterVanNostrand is a code owner

@vmx vmx Awaiting requested review from vmx vmx will be requested when the pull request is marked ready for review vmx is a code owner

Assignees
No one assigned
Labels
cryptocomputelab CryptoComputeLab work NSE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dignifiedquire @porcuquine @cryptonemo @keyvank @DrPeterVanNostrand