This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Changing OnEpochTickEnd to CronTick #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
pushed a commit
that referenced
this pull request
Dec 31, 2021
ZenGround0
pushed a commit
that referenced
this pull request
Dec 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the recommendations in issue #721. This is also a serious confusion I had when first engaging with the code base- I didn’t understand that EpochTick and Cron were necessarily the same thing, until @ZenGround0 said (almost 3 weeks into me working on this code!!) “marketcron” and “powercron”- then everything made sense. I think this naming will help. Unsure if this will also require any documentation updating or FIP action.... but it works.