Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(content): storage power consensus update #1176

Merged
merged 16 commits into from
Oct 8, 2020
Merged

fix(content): storage power consensus update #1176

merged 16 commits into from
Oct 8, 2020

Conversation

yiannisbot
Copy link
Collaborator

@yiannisbot yiannisbot commented Sep 23, 2020 •
edited
Loading

This PR is updating the Storage Power Consensus (SPC) section, which also includes the Storage Power Actor.

@zixuanzh I've done some minor touches here and there. I'll let you take it from here for more heavyweight edits as discussed.

A couple of notes and TODOs:

  • The code blocks need updating. Please provide references and I can update accordingly.
  • Section 2.4.4.1 is a bit confusing. Didn’t have a good way of restructuring, but can do in the next round, unless you have suggestions.
  • Section 2.4.4.6 on Network recovery after halting: I’m not sure this belongs here. There might need to be a new subsection on what happens after halting, or a drand outage.

@yiannisbot yiannisbot added the scope: content Scope: Editing content of the spec label Sep 23, 2020
zixuanzh
zixuanzh previously approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@zixuanzh zixuanzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

nikkolasg
nikkolasg previously approved these changes Oct 8, 2020
View reviewed changes
@yiannisbot
Copy link
Collaborator Author

  • References to code have been updated.
  • Section 2.4.4.1 has been left in.
  • Section 2.4.4.6 on Network recovery after halting has been removed.

@yiannisbot yiannisbot changed the title Storage Power Consensus Update fix(content): storage power consensus update Oct 8, 2020
@yiannisbot yiannisbot merged commit 9fb87eb into master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikkolasg nikkolasg nikkolasg left review comments

@zixuanzh zixuanzh zixuanzh left review comments

Assignees

@zixuanzh zixuanzh

Labels
scope: content Scope: Editing content of the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yiannisbot @nikkolasg @zixuanzh