feat: allow no roundStartEpoch for existing rounds #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Glif RPC API calls are timing out, or when our system is broken and rounds are not advancing at all, allow the spark-api service to start, even though it cannot obtain the roundStartEpoch of the current round. Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
juliangruber
approved these changes
May 13, 2024
|
I was thinking more about this problem and would like to change the architecture of our round tracking. These incremental changes seem a bit hacky and increase the complexity too much. The first step on the new journey: #292 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Glif RPC API calls are timing out, or when our system is broken and rounds are not advancing at all, allow the spark-api service to start, even though it cannot obtain the roundStartEpoch of the current round.