feat: decouple round tracker from API routes #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework API handlers to get the current round from the database. Benefits: - This commit fixes the long-standing bug where the REST API returned different current round depending on which worker process received the request. This was caused by different timing when each worker process detected a new RoundStarted event. - The new architecture allows us to further decouple the round tracker from the API handler. We can run it in background to not block process startup or even extract it into a standalone service. Downsides: - More database queries. Before my changes, the current round was available in memory. Now we need to read it from the database. Affected endpoints: - `POST /measurements` - `GET /rounds/current` Note: it should be possible to rework the query recording a new measurement to obtain the current round number in a sub-query of the `INSERT` statement. Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
- Rework the query inserting new measurements to fetch the current round as part of the single INSERT statement. - Inline `getCurrentRound()` implementation into the single remaining place calling it - the handler for `GET /rounds/current`. Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
juliangruber
approved these changes
May 15, 2024
Co-authored-by: Julian Gruber <julian@juliangruber.com>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: decouple round tracker from API routes
Rework API handlers to get the current round from the database.
Benefits:
This commit fixes the long-standing bug where the REST API returned different current round depending on which worker process received the request. This was caused by different timing when each worker process detected a new RoundStarted event.
The new architecture allows us to further decouple the round tracker from the API handler. We can run it in background to not block process startup or even extract it into a standalone service.
Downsides:
POST /measurementsGET /rounds/currentNote: The next commit reworks the query recording a new measurement to obtain the current round number in a sub-query of the
INSERTstatement.perf: inline
getCurrentRound()Rework the query inserting new measurements to fetch the current round as part of the single INSERT statement.
Inline
getCurrentRound()implementation into the single remaining place calling it - the handler forGET /rounds/current.Links: