fix add on-contract-event
#304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested changes
May 16, 2024
bajtos
reviewed
May 16, 2024
Comment on lines
+3
to
+5
| import { createMeridianContract, provider } from './ie-contract.js' | ||
| import { onContractEvent } from 'on-contract-event' | ||
| import { RPC_URL, GLIF_TOKEN } from '../spark-publish/ie-contract-config.js' |
There was a problem hiding this comment.
I'd like to keep only one place where we are importing from spark-publish.
Would you mind re-exporting these constants in ./ie-contract.js?
Suggested change
| import { createMeridianContract, provider } from './ie-contract.js' | |
| import { onContractEvent } from 'on-contract-event' | |
| import { RPC_URL, GLIF_TOKEN } from '../spark-publish/ie-contract-config.js' | |
| import { RPC_URL, GLIF_TOKEN, createMeridianContract, provider } from './ie-contract.js' | |
| import { onContractEvent } from 'on-contract-event' |
bajtos
approved these changes
May 16, 2024
bajtos
requested changes
May 16, 2024
There was a problem hiding this comment.
I think we can fix the problem by adding polling: true to the JsonRpcApiProvider options.
https://docs.ethers.org/v6/api/providers/jsonrpc/#JsonRpcApiProviderOptions
|
We don't need this change anymore, see #306 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by filecoin-station/on-contract-event#3