Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use polling for reading on-chain events #306

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented May 16, 2024

Lotus does not support filters when using JSON-RPC, see filecoin-project/lotus#11589

This PR supersedes #304

Lotus does not support filters when using JSON-RPC.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
Copy link
Member Author

bajtos commented May 16, 2024

Let's get this landed to observe how the new setup behaves in production.

@bajtos bajtos merged commit b5eb05f into main May 16, 2024
8 checks passed
@bajtos bajtos deleted the fix-event-polling branch May 16, 2024 14:17
@bajtos
Copy link
Member Author

bajtos commented May 16, 2024

@juliangruber hindsight please 🙏🏻

@bajtos
Copy link
Member Author

bajtos commented May 16, 2024

@juliangruber No more eth_getFilterChanges errors in spark-api logs after I deployed my change. (I checked 25 minutes after deploying the fix.)

@bajtos bajtos mentioned this pull request May 16, 2024
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants