Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #667: Replaced var with const and added strict mode in fs.readdir.spec.js #675

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Fixed #667: Replaced var with const and added strict mode in fs.readdir.spec.js #675

merged 2 commits into from
Jan 31, 2019

Conversation

jatinkumarg
Copy link
Contributor

Added 'use strict' at the top of the page and substituted var with either const or let data type.

@codecov-io
Copy link

codecov-io commented Jan 25, 2019 •
edited

Codecov Report

Merging #675 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #675   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...ea3488c. Read the comment docs.

@jatinkumarg jatinkumarg changed the title Replaced var with either const or let and added strict mode in fs.readdir.spec.js Fixed #667: Replaced var with either const or let and added strict mode in fs.readdir.spec.js Jan 25, 2019
@jatinkumarg jatinkumarg changed the title Fixed #667: Replaced var with either const or let and added strict mode in fs.readdir.spec.js Fixed #667: Replaced var with const and added strict mode in fs.readdir.spec.js Jan 28, 2019
humphd
humphd approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@humphd humphd merged commit 0380a81 into filerjs:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jatinkumarg @codecov-io @humphd