Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Sorting and removing unused usings #11010

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Code Quality: Sorting and removing unused usings #11010

merged 1 commit into from
Jan 14, 2023

Conversation

QuaintMako
Copy link
Contributor

What has been done

  • Removed any unused using.
  • Sorted all existing using.

Validation
How did you test these changes?

  • Built and ran the app

hecksmosis
hecksmosis approved these changes Jan 14, 2023
View reviewed changes
Copy link
Contributor

@hecksmosis hecksmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems none of these are used.

ferrariofilippo
ferrariofilippo approved these changes Jan 14, 2023
View reviewed changes
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I ran the code cleanup tool and there are no other unneccessary using

yaira2
yaira2 approved these changes Jan 14, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jan 14, 2023
@yaira2 yaira2 merged commit 3e26ad1 into files-community:main Jan 14, 2023
@yaira2 yaira2 changed the title Code Quality : Sorting and removing useless usings. Code Quality: Sorting and removing unused usings Jan 14, 2023
@hecksmosis hecksmosis mentioned this pull request Feb 14, 2023
Merged
1 task
@QuaintMako QuaintMako deleted the UsingClean branch February 28, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@hecksmosis hecksmosis hecksmosis approved these changes

@ferrariofilippo ferrariofilippo ferrariofilippo approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuaintMako @yaira2 @hecksmosis @ferrariofilippo