Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to set tags on read-only folders #7558

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Ability to set tags on read-only folders #7558

merged 1 commit into from
Jan 12, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jan 12, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Folders with a custom icon are set as "read-only". To save the tag remove the RO attribute, write the tag and restore the attribute.

@yaira2 yaira2 self-requested a review January 12, 2022 15:31
yaira2
yaira2 approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 12, 2022
@yaira2 yaira2 merged commit 4f13afe into files-community:main Jan 12, 2022
@yaira2 yaira2 mentioned this pull request Jan 12, 2022
Closed
@gave92 gave92 deleted the fixes_7534 branch January 12, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Folder tags won't save on folders with custom icons
2 participants
@gave92 @yaira2