Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced minimum sidebar width from 250 to 180 #7725

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Reduced minimum sidebar width from 250 to 180 #7725

merged 2 commits into from
Jan 17, 2022

Conversation

oleklukasiewicz
Copy link
Contributor

Reduced minimum sidebar width

Resolved / Related Issues

Details of Changes

  • Changed the constant responsible for the minimum width of the sidebar

Validation

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2
Copy link
Member

yaira2 commented Jan 16, 2022

@aleksanderlukasiewicz before we merge this, can you add your agreement to #7625?

yaira2
yaira2 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 17, 2022
@yaira2 yaira2 merged commit 432a541 into files-community:main Jan 17, 2022
@yaira2 yaira2 mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@winston-de winston-de Awaiting requested review from winston-de

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleklukasiewicz @yaira2