doc fixes #1262
doc fixes #1262
Conversation
|
If there are selenium UI results for this code they will be at filesenderuici@cf60ad2 |
… rm Blog from 'Social' link
Also set more appropriate heading for docs/v2.0/faq/index.md
|
If there are selenium UI results for this code they will be at filesenderuici@e7fcb7e |
|
|
||
| Extract SimpleSAMLphp in a suitable directory and create symlink: | ||
|
|
||
| ``` | ||
| mkdir -p /opt/filesender | ||
| cd /opt/filesender | ||
| tar xvzf /root/src/simplesamlphp-1.15.4.tar.gz | ||
| ln -s simplesamlphp-1.15.4 simplesaml | ||
| tar xvzf /tmp/simplesamlphp-1.17.1.tar.gz |
There was a problem hiding this comment.
We're at 1.19.5 already :)
|
Thank you for the PR :) Only one thing caught my attention while reading over things... I am not sure why session_cookie_path was removed in this PR. It seems to be still referenced in https://github.com/filesender/filesender/blob/development/includes/init/init_web.php#L45 Other than that (which I am happy to bring back post merge) everything looks good. |
|
Hmm, I see now that we went from 2 docs for session_cookie_path down to the correct one doc stanza for session_cookie_path :) |
Mostly no longer working URLs (e.g. due to the SimpleSAMLphp web site changes), http links where https could be used, broken relative documentation URLs, etc.
(I started out with very targeted commits but ultimately lumpted together more changes in cf60ad2 since you may want to squash all those on merge anyway.)
The docs are still a big mess IMHO but now with fewer broken links.
Also note that https://filesender.wordpress.com/ still exists but hasn't been updated in years.
(The same goes for https://twitter.com/filesender which I left in
docs/socialmedia.mdfor now, otherwise the page would essentially be empty after having removed references to the no longer functional http://blog.filesender.org/.)