Skip to content
This repository has been archived by the owner on Mar 16, 2023. It is now read-only.

Example image data not appropriately obfuscated #22

Closed
professorhantzen opened this issue Jun 30, 2018 · 2 comments
Closed

Example image data not appropriately obfuscated #22

professorhantzen opened this issue Jun 30, 2018 · 2 comments

Comments

@professorhantzen
Copy link

It would be possible to figure out the secret from the information provided. The supplied public/private key pair should not be considered safe for holding funds. Also, if the intention in masking the public addresses is to maintain privacy, the provided portions are readily grep-able within any ledgers accountState to reveal the full address. (Information also useful in unmasking the secret.)

I would attempt to convey this information privately, but the repository has already been forked several times. (A safer way to provide examples might be to paste over the real addresses with dummy/unused accounts or random values, prior to taking a screenshot.)

@Ponderjaunt
Copy link

Ponderjaunt commented Jun 30, 2018 via email

@filidorwiese
Copy link
Owner

filidorwiese commented Jul 1, 2018

Thanks for your concern. The account mentioned in the image is actually dummy. The obfuscation in the image was to illustrate the fact that the private key should be secret. I'll make a new version of the image to make that more clear.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants