Skip to content

Commit

Permalink
Remove SkShader.Empty from CanvasKit
Browse files Browse the repository at this point in the history
SkShaders::Empty may be easy to expose, but that doesn't mean we should.
It shouldn't even be public, but Chrome uses it in one place.

Change-Id: I398a5e6f782990a7baec0d9b1d0018f7456ff15f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260956
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
  • Loading branch information
brianosman authored and Skia Commit-Bot committed Dec 19, 2019
1 parent c76ac8e commit 77742c3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 3 additions & 0 deletions modules/canvaskit/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- `CanvasKit.SaveLayerInitWithPrevious` and `CanvasKit.SaveLayerF16ColorType` constants.

### Removed
- `SkShader.Empty`

## [0.10.0] - 2019-12-09

### Added
Expand Down
1 change: 0 additions & 1 deletion modules/canvaskit/canvaskit_bindings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1342,7 +1342,6 @@ EMSCRIPTEN_BINDINGS(Skia) {
return SkShaders::Blend(mode, dst, src, &m);
}))
.class_function("Color", select_overload<sk_sp<SkShader>(SkColor)>(&SkShaders::Color))
.class_function("Empty", &SkShaders::Empty)
.class_function("_Lerp", optional_override([](float t, sk_sp<SkShader> dst, sk_sp<SkShader> src)->sk_sp<SkShader> {
return SkShaders::Lerp(t, dst, src, nullptr);
}))
Expand Down

0 comments on commit 77742c3

Please sign in to comment.