Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch possible exceptions of mapOutputs function #1142

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

Phill101
Copy link
Contributor

@Phill101 Phill101 commented Aug 23, 2019

fix for #1138
Idea is catch every exception that may happen in function that provided to Endpoint#mapOutput from Mapper.

@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #1142 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1142   +/-   ##
=======================================
  Coverage   80.51%   80.51%           
=======================================
  Files          54       54           
  Lines        1016     1016           
  Branches       32       32           
=======================================
  Hits          818      818           
  Misses        198      198
Impacted Files Coverage Δ
core/src/main/scala/io/finch/internal/Mapper.scala 100% <100%> (ø) ⬆️
core/src/main/scala/io/finch/Endpoint.scala 72.57% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eaeedf...a543704. Read the comment docs.

@sergeykolbasov
Copy link
Collaborator

Thanks, @Phill101!
LGTM

/cc @vkostyukov @rpless

@sergeykolbasov
Copy link
Collaborator

Would you like to add a spec that reproduces & covers #1138?

@Phill101
Copy link
Contributor Author

Phill101 commented Aug 26, 2019

added small fix

Would you like to add a spec that reproduces & covers #1138?

yep. In progress

@rpless
Copy link
Collaborator

rpless commented Aug 26, 2019

@sergeykolbasov Yeah this LGTM as well.

Copy link
Collaborator

@vkostyukov vkostyukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @Phill101!

@Phill101 Phill101 force-pushed the safe-mapOutput branch 3 times, most recently from c818d99 to a796e7a Compare August 26, 2019 19:39
@Phill101
Copy link
Contributor Author

Added test. Probably it has not better name.

@sergeykolbasov
Copy link
Collaborator

Thanks, @Phill101! I think it's good

@sergeykolbasov sergeykolbasov merged commit 877223c into finagle:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants