-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch possible exceptions of mapOutputs function #1142
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1142 +/- ##
=======================================
Coverage 80.51% 80.51%
=======================================
Files 54 54
Lines 1016 1016
Branches 32 32
=======================================
Hits 818 818
Misses 198 198
Continue to review full report at Codecov.
|
Thanks, @Phill101! /cc @vkostyukov @rpless |
Would you like to add a spec that reproduces & covers #1138? |
021af4b
to
e1e9943
Compare
added small fix
yep. In progress |
@sergeykolbasov Yeah this LGTM as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @Phill101!
c818d99
to
a796e7a
Compare
a796e7a
to
a543704
Compare
Added test. Probably it has not better name. |
Thanks, @Phill101! I think it's good |
fix for #1138
Idea is catch every exception that may happen in function that provided to Endpoint#mapOutput from Mapper.