paramsNonEmpty returns NonEmptyList[A] #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeykolbasov
force-pushed
the
params-non-empty
branch
2 times, most recently
from
7262942
to
7f0f5a0
Compare
Current coverage is
|
| @@ -337,11 +338,13 @@ trait Endpoints { | |||
| * at least one element) multi-value query-string param `name` from the request into a `Seq` or | |||
| * raises a [[Error.NotPresent]] exception when the params are missing or empty. | |||
| */ | |||
| def paramsNonEmpty(name: String): Endpoint[Seq[String]] = | |||
| def paramsNonEmpty(name: String): Endpoint[NonEmptyList[String]] = | |||
There was a problem hiding this comment.
How do you feel about introducing a new function paramsNel and keeping the old one (behind deprecation)? I want to keep the API unchanged and I think paramsNel sounds like a reasonable name.
There was a problem hiding this comment.
Okay, let's introduce new method
sergeykolbasov
force-pushed
the
params-non-empty
branch
4 times, most recently
from
54e4b6f
to
b28454b
Compare
| */ | ||
| def paramsNel(name: String): Endpoint[NonEmptyList[String]] = | ||
| option(items.ParamItem(name))(requestParams(name)).mapAsync({ | ||
| case values if values.exists(_.nonEmpty) => |
There was a problem hiding this comment.
Can we simplify that and perform just a single traversal? Something like:
.mapAsync { values => values.filter(_.nonEmpty) match {
case hd :: tl => Future.value(NonEmptyList(hd, tl))
case _ => Future.exception(Error.NotPresent(items.ParamItem(name)))
}}There was a problem hiding this comment.
Emh, but in that case it could contain empty parameters
sergeykolbasov
force-pushed
the
params-non-empty
branch
from
b28454b
to
fdf1b08
Compare
| @@ -24,6 +23,10 @@ import shapeless._ | |||
| */ | |||
| object Main extends App { | |||
|
|
|||
| (1,2,3) match { | |||
There was a problem hiding this comment.
I should go sleep :(
sergeykolbasov
force-pushed
the
params-non-empty
branch
from
fdf1b08
to
98f8b1e
Compare
|
Thanks @imliar! Merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was discussed earlier: #577 (comment)