Introduce finch-generic module

[ilya-murzinov]

Before:

import io.finch._
val e = Endpoint.derive[Foo].fromParams

After:

import io.finch._
import io.finch.generic_
val e = deriveFor[Foo].fromParams

Resolves #528

[codecov-io]

Codecov Report

Merging #716 into master will increase coverage by 1.22%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
+ Coverage   79.78%   81.01%   +1.22%     
==========================================
  Files          35       37       +2     
  Lines         653      653              
  Branches       18       21       +3     
==========================================
+ Hits          521      529       +8     
+ Misses        132      124       -8

Impacted Files	Coverage Δ
core/src/main/scala/io/finch/Endpoint.scala	76.69% <ø> (+1.13%)	⬆️
...c/src/main/scala/io/finch/generic/FromParams.scala	50% <ø> (ø)
...ain/scala/io/finch/generic/GenericDerivation.scala	100% <100%> (ø)
...eric/src/main/scala/io/finch/generic/package.scala	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5584ddb...f6093f9. Read the comment docs.

[ilya-murzinov]

@vkostyukov @rpless any chance to get a feedback here?

[vkostyukov]

Thanks @ilya-murzinov! (Sorry it took me a while to review). This LGTM!

[vkostyukov]

Since we're moving this anyway, how about we change that to deriveEndpoint[A]?

[ilya-murzinov]

Done

[rpless]

Aside from renaming deriveFor, 👍

[vkostyukov]

Hey @ilya-murzinov! Any chance you'd be able to update this branch today/tomorrow? I was hoping to get the release out and wanted to include these changes there as well.

[ilya-murzinov]

Sure, will do tomorrow!

…

On Wed, Mar 29, 2017, 20:34 Vladimir Kostyukov ***@***.***> wrote: Hey @ilya-murzinov <https://github.com/ilya-murzinov>! Any chance you'd be able to update this branch today/tomorrow? I was hoping to get the release out and wanted to include these changes there as well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#716 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADiGKxE6q9vXxheyoAq6mS2uiLiRQTaOks5rqpYhgaJpZM4Ldr1x> .

[vkostyukov]

Sorry, mind dropping For? Just deriveEndpoint is perfectly fine.

[ilya-murzinov]

I kinda liked this 'for', but since you insist...

[vkostyukov]

Yeah, I can see why you might like it and yet I think it doesn't really add much readability. Also, I learn from Circe that has deriveDecoder and deriveEncoder.