Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - Add eslint hooks plugin #36

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

apanizo
Copy link
Contributor

@apanizo apanizo commented Mar 23, 2019

Description
This PR is a WIP one. I need some feedback from the authors. Happy to contribute and help to move forward.

Basically, after installing the eslint plugin for hooks, we have some warnings in the hook's code.

react-final-form-hooks/src/useField.js
38:5   warning  React Hook useEffect has a missing dependency: 'subscription'. Either include it or remove the dependency array 
38:18  warning  React Hook useEffect has a spread element in its dependency array. This means we can't statically verify whether you've passed the correct dependencies 

/react-final-form-hooks/src/useForm.js
35:6  warning  React Hook useCallback has a missing dependency: 'form'. Either include it or remove the dependency array  

/react-final-form-hooks/src/useFormState.js
18:59  warning  React Hook useEffect has a missing dependency: 'subscription'. Either include it or remove the dependency 
20:5   warning  React Hook useEffect has a spread element in its dependency array. This means we can't statically verify whether you've passed the correct dependencies 

Can you guys give some feedback about it?

@erikras
Copy link
Member

erikras commented Apr 12, 2019

Looks good to me!

@erikras erikras merged commit 35e6856 into final-form:master Apr 30, 2019
@erikras
Copy link
Member

erikras commented May 1, 2019

Published in v2.0.0.

@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants