Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript definition file #50

Merged
merged 4 commits into from
Jul 12, 2019
Merged

Update typescript definition file #50

merged 4 commits into from
Jul 12, 2019

Conversation

tobilen
Copy link
Contributor

@tobilen tobilen commented Jun 26, 2019

This incorporates the changes introduced in final-form with this commit, version 4.15.0 ( https://github.com/final-form/final-form/releases/tag/v4.15.0 )

@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #50   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          81     81           
  Branches       17     17           
=====================================
  Hits           81     81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80ebe2b...5c0480b. Read the comment docs.

@MarkAPhillips
Copy link

Please could this PR be reviewed and merged - I decided to use the repo on a project I am working on (with typescript) - I have added a work around for the time being but would be great if this PR is actioned upon. Please note this does fix the issue in relation to generic types as am using the typings directly in my codebase currently.

@tobilen
Copy link
Contributor Author

tobilen commented Jul 12, 2019

@erikras anything i can do to get this merged?

@erikras erikras merged commit a61e3fc into final-form:master Jul 12, 2019
@erikras
Copy link
Member

erikras commented Jul 12, 2019

Published in v2.0.1.

@tobilen tobilen deleted the patch-1 branch July 12, 2019 15:01
@lock
Copy link

lock bot commented Aug 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants