Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rpatters1 Not sure if you wanted to review this.
The
inject()
function in the bunder, which insertsHashURL
andRTFNotes
, was assuming that there would only be one line inplugindef()
that starts withreturn
and one line that starts withend
. This is not necessarily true, since a line of text inNotes
, for example, could start with either of these. (And theNotes
in the script I recently added did!)This PR changes
inject()
to get the last matching token. There's still an edge case here ifplugindef()
does not include areturn
statement (since it's not technically required) but does have a line starting withreturn
inNotes
. But since this repo seems to have an unofficial requirement for a properplugindef()
function with areturn
, I'm not worried about this.