Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EOS ngrams #72

Closed
sebpuetz opened this issue Oct 10, 2019 · 0 comments · Fixed by #76
Closed

Fix EOS ngrams #72

sebpuetz opened this issue Oct 10, 2019 · 0 comments · Fixed by #76
Assignees
Milestone

Comments

@sebpuetz
Copy link
Member

The ngram vocab currently brackets the <\s> marker and extracts ngrams from "<<\s>>". Those subwords aren't trained because the indices are never added to the subwords Vec in the vocab via:

            if word.word() == util::EOS {
                subword_indices.push(Vec::new());
                continue;
            }

It's fairly unlikely to encounter those ngrams anywhere but we should fix this once we figured out the bug.

@sebpuetz sebpuetz self-assigned this Oct 10, 2019
@danieldk danieldk added this to the release-0.7 milestone Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants