Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default values through clap, fix some unsensible defaults #48

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Set default values through clap, fix some unsensible defaults #48

merged 1 commit into from
Jun 13, 2019

Conversation

danieldk
Copy link
Member

The changed defaults are:

  • Context size: 5 -> 10
  • Dims: 100 -> 300
  • Epochs: 5 -> 15

@danieldk danieldk requested a review from sebpuetz June 12, 2019 17:37
@danieldk danieldk mentioned this pull request Jun 12, 2019
Closed
sebpuetz
sebpuetz requested changes Jun 12, 2019
View reviewed changes
finalfrontier-utils/src/util.rs Outdated Show resolved Hide resolved
@danieldk danieldk force-pushed the option-handling branch 2 times, most recently from d2b523a to 9d9c646 Compare June 12, 2019 18:28
@danieldk
Copy link
Member Author

@sebpuetz Good to go now? (I also updated the man pages with the new defaults.)

sebpuetz
sebpuetz requested changes Jun 13, 2019
View reviewed changes
Copy link
Member

@sebpuetz sebpuetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In tf-train-skipgram.1.md dirgram is missing in the models section

@danieldk
Copy link
Member Author

In tf-train-skipgram.1.md dirgram is missing in the models section

That's unrelated to this PR. This was also already fixed in #50 (this PR just needs to be rebased before merging).

@danieldk
Set default values through clap, fix some unsensible defaults
ff313d2 
The changed defaults are:

- Context size: 5 -> 10
- Dims: 100 -> 300
- Epochs: 5 -> 15
@danieldk danieldk merged commit 1e84919 into master Jun 13, 2019
@danieldk danieldk deleted the option-handling branch July 2, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealNicolasBourbaki RealNicolasBourbaki RealNicolasBourbaki requested changes

@sebpuetz sebpuetz sebpuetz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @sebpuetz @RealNicolasBourbaki