Encapsulate NdNorms array. #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealNicolasBourbaki
approved these changes
Oct 18, 2019
|
The coding-style here looks more consistent now :) |
sebpuetz
force-pushed
the
encapsulate-norms
branch
from
b71a3a6
to
002ae8f
Compare
danieldk
approved these changes
Oct 20, 2019
Encapsulate NdNorms array, provide interface through deref to Array1.
sebpuetz
force-pushed
the
encapsulate-norms
branch
from
002ae8f
to
08aaed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encapsulate NdNorms array, provide interface through deref to
Array1.
I also removed the
Normstrait that I didn't even know existed before. I assume that was planned as a compatibility layer if we introduced other norm chunks. Now that we're planning to stabilize the API and don't intend to add new chunks and features I think this can go away until we'd have to break the API anyways. With only theNormstrait for accessing a norm,NdNormsis useless unless `Norms' is imported.