Encapsulate Metadata's data. #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
requested changes
Oct 18, 2019
src/chunks/metadata.rs
Outdated
| @@ -12,7 +13,30 @@ use crate::io::{Error, ErrorKind, ReadMetadata, Result}; | |||
| /// | |||
| /// finalfusion metadata in TOML format. | |||
| #[derive(Clone, Debug, PartialEq)] | |||
| pub struct Metadata(pub Value); | |||
| pub struct Metadata { | |||
| data: Value, | |||
|
|
||
| impl Metadata { | ||
| /// Construct new `Metadata`. | ||
| pub fn new(data: Value) -> Self { |
There was a problem hiding this comment.
I think a From counterpart would be nice here as well.
There was a problem hiding this comment.
Tried to implement TryFrom<V> where V: Serialize, but that fails because of blanket impls...
--> src/chunks/metadata.rs:43:1
|
43 | impl<V> TryFrom<V> for Metadata where V: Serialize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: conflicting implementation in crate `core`:
- impl<T, U> std::convert::TryFrom<U> for T
where U: std::convert::Into<T>;
sebpuetz
force-pushed
the
encapsulate-metadata
branch
from
db41e76
to
95019b6
Compare
Restrict interface to Metadata's data, impl Deref(Mut) with target toml::Value for Metadata.
sebpuetz
force-pushed
the
encapsulate-metadata
branch
from
95019b6
to
3c50780
Compare
|
Is this and #90 good to go? |
danieldk
approved these changes
Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict interface to Metadata's data, impl Deref(Mut) with
target toml::Value for Metadata.