Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finance::Quote fails to retrieve quotes with tradeville method #269

Closed
besteru opened this issue May 9, 2023 · 5 comments · Fixed by #287
Closed

Finance::Quote fails to retrieve quotes with tradeville method #269

besteru opened this issue May 9, 2023 · 5 comments · Fixed by #287
Assignees
Labels
module malfunction report about malfunctioning module

Comments

@besteru
Copy link

besteru commented May 9, 2023

seems that the tradevile.ro page no longer returns a static HTML that can be parsed.
It now returns a page that refers to a big separate .js file that looks that is doing all rendering.

In order for tradeville method to work, the .js should be executed.

as an alternative to retrieve quotes for BVB, the main BVB site return a static page with all the quote data (but in different places/different tags:
https://bvb.ro/FinancialInstruments/Details/FinancialInstrumentsDetails.aspx?s=BRD

@bpschuck bpschuck added the module malfunction report about malfunctioning module label May 9, 2023
@bpschuck
Copy link
Contributor

bpschuck commented May 9, 2023

Thank you for the notification. It may be some time before one of the F::Q team members can address this. However, anyone else is free to tackle the issue or create a BVB.pm module and submit a pull request.
It's also helpful to include example symbols for querying data. While the test files (in this case tradeville.t) will have symbols, sometimes they symbols that at outdated and no longer in use.
Thank you.

@bpschuck
Copy link
Contributor

@besteru, I'm looking at the bvb.ro source noted. What I don't see is a currency specifically returned in the HTML. But, looking at the a few non-Romanian securities like ADS, it seems that all prices are returned in RON. Is that a safe assumption if a BVB.pm was created to replace Tradeville.pm?

@besteru
Copy link
Author

besteru commented May 22, 2023

BVB is the main site of the Bucharest Stock Exchange (Bursa de Valori Bucuresti). So all prices are in RON.
Tradeville.pm had the alias as "romania" so its main purpose was to return the Romanian stocks. It does not make much sense to retrieve NYSE stocks in RON... But we need a way to retrieve BVB stocks. And currencies can be converted.

@bpschuck
Copy link
Contributor

Obviously I know that currencies can be converted. Still, I've learned over the years that making assumptions is not usually the best path. Personally, I may not be able to commit time to this for at least a few weeks, if not a couple months. F::Q being OpenSource community supported software, anyone is free to contribute.

@bpschuck bpschuck self-assigned this May 24, 2023
@bpschuck
Copy link
Contributor

@besteru If you are comfortable with manipulating files in your Perl library trees, I believe I have a BVB.pm module just about ready. You may need to edit your Quote.pm module depending on what your current F::Q version is. There are a few other changes coming in v1.56 that are already represented in my branch at https://github.com/bpschuck/finance-quote/tree/bvb. I may push a 1.55_02 to CPAN later this weekend, but it could be a few days instead. I still need to remove Tradeville.pm and references to it and some other cleanup (sometimes the housekeeping in preparing for an official release is more burdensome than the coding work itself).

@bpschuck bpschuck linked a pull request May 29, 2023 that will close this issue
bpschuck added a commit that referenced this issue May 29, 2023
  * Replaced Tradeville.pm with BVB.pm - Issue #269
	* Added new TwelveData module
	* Updated YahooJSON.pm and CurrencyRates/YahooJSON.pm to use https://query2.finance.yahoo.com/v11 - PR #284
	* Bourso.pm - Squash anything but numbers and period in quote values.
	* Renamed MStarUK.pm to MorningstarUK.pm
	* Added get_features method - PR #260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module malfunction report about malfunctioning module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants