Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed $symbol to $stock in calls to store_date #194

Merged
merged 1 commit into from Jul 27, 2021
Merged

Changed $symbol to $stock in calls to store_date #194

merged 1 commit into from Jul 27, 2021

Conversation

bpschuck
Copy link
Contributor

Fix for issue #174. The symbol derived from parsing the HTML retrieved for some securities does not match the stock requested. Calling the store_date method with the symbol instead of $stock does not populate the correct hash.

@bpschuck bpschuck merged commit 90f2b13 into finance-quote:master Jul 27, 2021
@bpschuck bpschuck deleted the Bourso branch July 27, 2021 16:41
bpschuck added a commit that referenced this pull request Jul 3, 2022
        * Quote.pm - Fixed logic for FQ_LOAD_QUOTELET starting with "-defaults"
          reported in issue #197. PR #199.
        * AlphaVantage currency module: Don't recurse infinitely when exchange
          rate is less than .001 (PR 193)
        * Bourso.pm - Fixed data bug reported in issue #174 with PR #194.
        * TSP.pm - Minor fix for URL used to retrieve data. PR #195.
          Note: URL was changed after the PR was merged.
          Module remains in a non-working status.
        * TesouroDireto.pm - New module for Brazilian's National Treasury
          public bounds. PR #198.
        * Bloomberg.pm - Update Bloomberg class names #205. Correct html
          parsing errors.
        * MorningstarCH.pm - Re-enabled and fixed in #207.
        * ZA.pm - Change to return price from sharenet in major denomination.
          PR #208.
        * Changes to SourceForge project website HTML files.
        * Add [Prereqs] to dist.ini. #215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant