Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a self-reference in TMX.pm documentation #345

Merged
merged 3 commits into from Sep 16, 2023

Conversation

dhgutteridge
Copy link
Contributor

No description provided.

@bpschuck
Copy link
Contributor

@dhgutteridge,
Thank you for PR. We've been asking people to also update "Modules-README.yml" and "Changes" to minimize housekeeping done in preparation of pushing a release to CPAN. In "Changes" we have been adding the most recent to the top of the list under the {{$NEXT}} tag. In "Modules-README.yml", just update the Changed: date for the module.

@bpschuck bpschuck self-assigned this Sep 15, 2023
@dhgutteridge
Copy link
Contributor Author

Sorry about that, should be added as you need now. (These should be auto-squishable by GitHub, I think.)

@bpschuck
Copy link
Contributor

Not a problem. The "Hacker's Guide" notes those changes for new modules, but doesn't mention instructions or steps for those submitting PRs for fixes and updates. A ToDo for the module is creating a Contributing.pod that would contain more details than Hackers-Guide. When completed, the Contributing doc it would likely supersede the Hacker's Guide.
Thanks again.

@bpschuck bpschuck merged commit bb53793 into finance-quote:master Sep 16, 2023
1 check passed
bpschuck added a commit that referenced this pull request Dec 31, 2023
	* Fixed XETRA, Tradegate and SInvestor after webpage was restructured - Issue #350
	* Fidelity.pm temporarily disabled - Issue #346
	* Finanzpartner.pm - Fix scraper, did not work if quote was higher than the previous day's quote.
	* GoogleWeb.pm - Updated to retrieve mutual fund and BATS prices - Issue #355
	* BSEIndia.pm - Updated to use standardized data file at URL
	  https://www.bseindia.com/download/BhavCopy/Equity/BSE_EQ_BHAVCOPY_{DDMMYYYY}.ZIP
	  Eliminated need to use temp folders by storing standardized file data from URL into a variable.
	  Updated names of source fields to conform to those in the standardized data file
	* IndiaMutual.pm - Eliminated need to use temp folders by storing nav file data from URL into a variable.
	* TMX.pm - Correct a self-reference in documentation - PR #345
	* Stooq.pm - Added new currencies and a fix for commodities' prices
	* YahooWeb.pm - Skip rows in the price table where the prices are "-".
	  This seems to happen sometimes with TIAA (and perhaps other) securities
	  including TILIX and QCILIX
	* TSP.pm - Was not returning hash when the HTTP GET failed completely
	  or the content did not contain the expected CSV file. - Issue #338
	* BSEIndia.pm - Removed print when symbol not found - Issue #335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants