Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed XETRA, Tradegate and SInvestor after webpage was restructured #353

Merged
merged 5 commits into from Dec 17, 2023

Conversation

mumpitzstuff
Copy link
Contributor

Fixes #350.

@bpschuck
Copy link
Contributor

Awesome! Thanks for the quick response. BTW - Prefer most recent changes at the top of the list in Changes file.

@bpschuck bpschuck self-assigned this Nov 27, 2023
@bpschuck bpschuck added modified scraping scraping modified mostly to follow website modifications next release labels Nov 27, 2023
@mumpitzstuff
Copy link
Contributor Author

changes reordered...

@mumpitzstuff
Copy link
Contributor Author

@bpschuck Is something missing?

@bpschuck
Copy link
Contributor

@bpschuck Is something missing?

No sir. I've just been extremely busy at the day job and personal life. Besides holiday related goodies, getting my late father's house prepped for sale (including repairing hurricane damage).

@mumpitzstuff
Copy link
Contributor Author

Oh sry then please excuse my impatience.

@bpschuck
Copy link
Contributor

bpschuck commented Dec 2, 2023

Not a problem.

@bpschuck
Copy link
Contributor

@mumpitzstuff - Before merging the pull request I executed the test suites for the 3 modules. t/extra.t and t/tradegate.t failed with errors. t/sinvestor.t successfully completed all 94 planned tests. I did not investigate further, but usually failures occur due to symbols no longer being valid. If you could please review and fix the test suites that would be greatly appreciated.
Thank you once again for contributing.

mumpitzstuff and others added 2 commits December 17, 2023 21:01
- testcases fixed (used bond does not exist anymore)
@mumpitzstuff
Copy link
Contributor Author

The bond used for the tradegate and xetra tests was not valid anymore. Therefore i had to use another one (tests fixed). But now an error occured because bonds seems to have a different output. Therefore i adjusted sinvestor, xetra and tradegate another time to fix this issue hopefully.

@bpschuck bpschuck merged commit a2f49a7 into finance-quote:master Dec 17, 2023
1 check passed
@bpschuck
Copy link
Contributor

PR merged. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modified scraping scraping modified mostly to follow website modifications next release
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

XETRA.pm no longer working
2 participants