Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed char type to uint8_t and fixed std::string_view type cast werror #8

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

alexchunlin
Copy link
Contributor

@alexchunlin alexchunlin commented Jul 30, 2023

Description

These were the changes that made the compiler stop screaming

Motivation and Context

Closes #7

How has this been tested?

Demo builds and runs on windows 11 && UE5.2.1

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.

Copy link
Owner

@finger563 finger563 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I had changed some of the lower level (RtpPacket) containers over to uint8_t but hadn't needed to change the higher level stuff when compiling with clang. Glad you got it working / tested on Windows 👍

@finger563 finger563 merged commit 690fc4b into finger563:main Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build errors relating to use of char type and string_view
2 participants