Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rtsp): Updated rtsp to explicit types #99

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

finger563
Copy link
Contributor

Description

  • Updated rtp/jpeg classes to use strongly typed types (uint8_t instead of char, uintX_t instead of int) for better compiler support to prevent conversion warnings / errors and to ensure data does not change due to type change.
  • Updated display_frame python script to not have frame in it but instead to show image from comand line

Motivation and Context

As these files can be used in other projects (such as unreal-rtsp-display which may use many compilers across many platforms, we should more correctly match the variable type to the expected type to prevent type conversions which can cause data errors or compiler warnings/errors.

How has this been tested?

See finger563/unreal-rtsp-display#8 for example PR fixing the issues reported above.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Updated rtp/jpeg classes to use strongly typed types (uint8_t instead of char, uintX_t instead of int) for better compiler support to prevent conversion warnings / errors and to ensure data does not change due to type change.
* Updated display_frame python script to not have frame in it but instead to show image from comand line
@finger563 finger563 self-assigned this Jul 31, 2023
@finger563 finger563 added bug Something isn't working enhancement New feature or request build rtsp labels Jul 31, 2023
@finger563 finger563 merged commit 0aaa986 into main Jul 31, 2023
39 checks passed
@finger563 finger563 deleted the feature/rtsp-type-safety branch July 31, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build enhancement New feature or request rtsp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant