Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#176 Fix console error on too many active WEBGL contexts #484

Merged
merged 2 commits into from
Oct 9, 2019
Merged

#176 Fix console error on too many active WEBGL contexts #484

merged 2 commits into from
Oct 9, 2019

Conversation

Chandra158
Copy link
Contributor

@Chandra158 Chandra158 commented Oct 5, 2019 •
edited
Loading

Description

  • Fixes error/warning in browser console on opening too many WEBGL contexts.
  • Previous console logs :
    • Chrome : WARNING: Too many active WebGL contexts. Oldest context will be lost.
    • Firefox : Error: WebGL warning: <SetDimensions>: Exceeded 16 live WebGL contexts for this principal, losing the least recently used one.

@Chandra158 Chandra158 changed the title Fix console error on too many active WEBGL contexts #176 Fix console error on too many active WEBGL contexts Oct 5, 2019
@Chandra158 Chandra158 mentioned this pull request Oct 5, 2019
Closed
@Valve
Copy link
Contributor

Valve commented Oct 5, 2019

thanks @ProcrastinatorCp will review on Monday

@jonashaag
Copy link
Contributor

Thanks for the patch.

Does this work at all? Are browsers actually doing anything when WEBGL_lose_context is called?

@Chandra158
Copy link
Contributor Author

Chandra158 commented Oct 9, 2019 •
edited
Loading

@jonashaag
Not sure about the internals. I have only tested the console error/warning fix in developer tools.
Tested with executing fingerprintReport() in a loop in index.html.

@jonashaag
Copy link
Contributor

Ok. Can't hurt I guess. Can you please run npm run lint and re-commit?

@jonashaag jonashaag merged commit ac13f6f into fingerprintjs:master Oct 9, 2019
@Chandra158 Chandra158 deleted the gh-176 branch October 9, 2019 15:15
@BafS BafS mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chandra158 @Valve @jonashaag