Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon: new version, switch to 64-bit arch #801

Merged
merged 3 commits into from
Jul 27, 2021
Merged

Conversation

dmacks
Copy link
Member

@dmacks dmacks commented Jun 18, 2021

The .so is built flat installed in bin/ as in previous versions; I
have no idea how this file might get used so I don't know if the
location and/or binary library flags are correct.

The .so is built flat installed in bin/ as in previous versions; I
have no idea how this file might get used so I don't know if the
location and/or binary library flags are correct.
@dmacks dmacks added the waiting for owner waiting for a reply from package owner label Jul 17, 2021
@dmacks
Copy link
Member Author

dmacks commented Jul 17, 2021

Ping @microtherion. Will push in a few days if no response.

microtherion
microtherion previously approved these changes Jul 19, 2021
Copy link
Contributor

@microtherion microtherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this all looks plausible to me (haven't used it in years).

I don't know the reason for the .so, nor do I think I ever knew (possibly having to do with an extension mechanism?).

Only question I have is why the dependency on readline was dropped; ISTR that icon has a REPL, so readline is potentially useful. Did our policies on this change?

PS: Feel free to take over as maintainer, if you wish.

@dmacks
Copy link
Member Author

dmacks commented Jul 19, 2021

Doesn't access readline headers or link against anything except x11. I added some instrumentation to the build to help catch it.

I don't actually use this thing at all, I'm just working on upgrading everything that used older versions of readline.

@dmacks
Copy link
Member Author

dmacks commented Jul 27, 2021

Maintainer seems okay; I don't want to maintain it, just minimal work to keep existing packages modernly buildable

@dmacks dmacks merged commit 2cd840d into fink:master Jul 27, 2021
@dmacks dmacks deleted the icon-update branch July 27, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for owner waiting for a reply from package owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants