test for fixed RuntimeVars bug that could create runtime chaos

fink · Jul 29, 2016 · 21f9db8 · 21f9db8
1 parent 17d023c
commit 21f9db8
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/perlmod/Fink/Validation.pm b/perlmod/Fink/Validation.pm
@@ -1412,6 +1412,15 @@ sub validate_info_component {
 		$looks_good = 0 unless _require_dep(\%options, { build => {'fink' => '0.32'} }, 'use of RuntimeDepends', $filename);
 	}
 
+	# A bug related to RuntimeVars ordering was fixed; it could
+	# trigger runtime errors in a certain situation. Test here is a
+	# heuristic for that situation.
+	$value = $properties->{runtimevars};
+	if (defined $value and $value =~ /$/) {
+		warn "  heuristic match\n";
+		$looks_good = 0 unless _require_dep(\%options, { build => {'fink' => '0.39.4'} }, 'use of shell variables in RuntimeVars variable values', $filename);
+	}
+
 	# check syntax of each line of Shlibs field
 	$value = $properties->{shlibs};
 	if (defined $value) {