Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using historyjs the global window.History object is used causing Uncaught TypeError: Cannot read property 'Adapter' of undefined #108

Closed
tedsteen opened this issue Mar 12, 2013 · 2 comments · Fixed by #110

Comments

@tedsteen
Copy link
Contributor

When using requirejs the global window.History object might not be set when pagerjs initializes. And as we are supposed to set the pager.Href5.history when using historyjs shouldn't that be used here in place of window.History?
Same goes for jquery (it is properly injected through require but not used, I was probably lucky here)

@finnsson
Copy link
Owner

I will have to take a look at this when I get home on monday. I dont think Ive ever tested historyjs + requirejs so I guess I have some testing to do. Thanks for the report.

Sent from my iPhone

On Mar 12, 2013, at 14:48, Ted Steen notifications@github.com wrote:

When using requirejs the global window.History object might not be set when pagerjs initializes. And as we are supposed to set the pager.Href5.history when using historyjs shouldn't that be used here in place of window.History?
Same goes for jquery (it is properly injected through require but not used, I was probably lucky here)


Reply to this email directly or view it on GitHub.

@finnsson
Copy link
Owner

finnsson commented May 4, 2013

Just cleaning up old issues. The pull request is merged.

@finnsson finnsson closed this as completed May 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants