587 ViewResearch addition #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriswest
requested review from
kriswest,
rikoe,
donbasuno,
ggeorgievx,
hughtroeger,
mattjamieson and
mistryvinay
kriswest
added
intents
Context Data & Intents
15 tasks
kriswest
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
LGTM apart from:
- One link that needs correcting (added a suggestion)
- Inclusion of ViewProfile changes in the PR - not a problem if that is also adopted (as is likely to happen) but generally PRs should only build on each other if they actually extend each other
hughtroeger
approved these changes
Mar 31, 2022
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
24 tasks
|
@finos/fdc3-maintainers any blockers for not approving this one? |
29 tasks
|
Needs a CHANGELOG.md entry |
mistryvinay
changed the base branch from
master
to
context-data-and-intents-consolidated-update-branch
kriswest
merged commit 1aec367
into
finos:context-data-and-intents-consolidated-update-branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a dependency between this PR and 600 View Profile ... just because some of the updates I make here build on the ones in View Profile (the update to intents/spec.md for example).